Skip to content

Add fix for tables in blockquotes #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andysteadbbc merged 1 commit into from
Feb 6, 2026
Merged

Add fix for tables in blockquotes #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions default-md-files/folder/some-file.md → default-md-files/folder/edge-cases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## This is a file in a folder
## Edge Cases that break the build

Bug fix from bbc/web repo. Code block in a NOTE blockquote.

Expand All @@ -19,4 +19,30 @@ Bug fix from bbc/web repo. Code block in a NOTE blockquote.
> );
> }
> `;
> ```
> ```


> **bold text
> Blockquotes with Unclosed Markdown Syntax. **This text is actually bold**


> Emoji shortcuts
> :warning: Be careful!


> Tables in blockquotes
> ---
> | Header | Value |
> |--------|-------|
> | a | b |


>
>
> Some text with blank spaces above


> Nested lists in blockquotes
> 1. Item one
> - Subitem
> 2. Item two
6 changes: 2 additions & 4 deletions src/markdown-to-html-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,8 @@ const parseToHTML = (markdown, options = {}) => {
textString += this.parser.parseInline(token.tokens)
} else if (token.type === 'space') {
textString += this.parser.parseInline([{ type: 'br', text: token.text, raw: token.raw }])
} else if (token.type === 'list') {
textString += marked.Renderer.prototype.list.call(this, token)
} else if (token.type === 'code') {
textString += marked.Renderer.prototype.code.call(this, token)
} else if (['list', 'code', 'hr', 'table'].includes(token.type)) {
textString += marked.Renderer.prototype[token.type].call(this, token) // use default renderer for these block-level tokens
} else {
textString += this.parser.parseInline(tokens)
}
Expand Down