Open
Conversation
Adds examples of: - PCM audio in WAV containers - JPEG-2000 video in MXF containers - H.264 video in MXF containers Also tidies the list of Flow examples to group by type.
Adds an example of Flow Storage using WAV containers and proxying the object traffic through the same origin as the API.
Tweaks client request methods to automatically raise on execptions, and include the response body in those exceptions (makes debugging failure causes much easier!)
Updates ingest script to accept a list of filenames (rather than an HLS manifest), and also support setting `ts_offset` and generally retiming Flows. Updates output script to remove hard MPEG-TS requirement - ffmpeg's probing is good enough to correctly detect the format.
Adds MOV and WAV container examples to the ingest scripts, using an additional test film at 50fps (alongside Big Buck Bunny at 30fps).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
ingest_hls.pyexample to handle non-HLS inputoutgest_file.pyexample to handle non-MPEGTS mediaJira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5513
Related PRs
N/A
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.