Add defensive nil checks to prevent container crashes from malformed requests#17
Merged
Conversation
…requests Adds nil pointer checks throughout HTTP request handling to prevent container crashes when proxying to upstream domains that send malformed requests. The goproxy library can pass requests with nil fields under certain edge cases (corrupted parsing, malformed CONNECT requests, TLS handshake failures). Changes: - Add nil checks for req, req.URL in all credential injectors and proxy handlers - Return graceful HTTP 400/500 error responses instead of panicking - Add validateRequest() helper to eliminate duplicate nil check code - Add errorResponse() helper for consistent error response creation - Add comprehensive unit tests for all nil pointer scenarios - Remove impossible checks (req.Header, credentials after init, ctx from goproxy) - Reduce hot-path logging overhead by removing logs from non-error paths All defensive checks log with "DEFENSIVE_CHECK:" prefix for production monitoring. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds nil pointer checks throughout HTTP request handling to prevent container crashes when proxying to upstream domains that send malformed requests. The goproxy library can pass requests with nil fields under certain edge cases (corrupted parsing, malformed CONNECT requests, TLS handshake failures).
Changes:
All defensive checks log with "DEFENSIVE_CHECK:" prefix for production monitoring.