fix uv install to fail properly on download errors#196
Merged
Conversation
Podman and Buildah default to the OCI image format, which does not support the SHELL instruction. Podman effectively ignores SHELL, so "pipefail" was never active. A failed "curl" piped into "sh" could exit zero and produce a broken image. Download to a temporary file first, then execute. Each step in the "&&" chain fails the build independently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Looks good - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHELLDockerfile instruction (Please support SHELL even in OCI builds containers/buildah#6460). Podman was ignoringSHELL, sopipefailwas never active. A failedcurlpiped intoshcould exit zero and produce a broken image.curl | shwith a download-then-execute pattern. Each step in the&&chain fails the build independently.Claude and I have run the following steps
make clean && make buildcompletes without theSHELL is not supported for OCI image formatwarninguv --versionworks in the built image/tmp/uv-install.shtemp file is cleaned upcurlstep (exit status 22)