Skip to content

Treat empty _in arrays as false, ie. #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvanoord merged 4 commits into from
Aug 25, 2025
Merged

Treat empty _in arrays as false, ie. #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e04d677
Treat empty _in arrays as false, ie.
u12206050 Aug 22, 2025
c082874
Remove tuple fix
u12206050 Aug 22, 2025
a647c86
Cleaner
u12206050 Aug 22, 2025
aff83e4
Remove comments
u12206050 Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/BccCode.Linq/Server/Filter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ private void _parse(string json)
else if (new[] { "_in", "_nin" }.Contains(key))
{
var array = JsonConvert.DeserializeObject<T[]>(value.ToString() ?? string.Empty);
if (array is null || array.Length == 0)
if (array is null)
{
throw new ArgumentException(
$"JSON filter rule is invalid. Array under {key} is null or empty.");
$"JSON filter rule is invalid. Array under {key} is null.");
}

deserializedJson[key] = array;
Expand Down
5 changes: 3 additions & 2 deletions tests/BccCode.Linq.Tests/FilterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,12 @@ public void should_cast_value_to_decimal_list()
}

[Fact]
public void should_throw_exception_on_empty_list()
public void should_allow_empty_list_in_in_operator()
{
var json = @"{ ""StringArrayProp"": { ""_in"": [] } }";

Assert.Throws<ArgumentException>(() => new Filter<TestClass>(json));
var ex = Record.Exception(() => new Filter<TestClass>(json));
Assert.Null(ex);
}

[Fact]
Expand Down
86 changes: 47 additions & 39 deletions tests/BccCode.Linq.Tests/Server/FilterToLambdaParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,45 +44,16 @@ public void should_get_correct_result_when_filter_has_one_logical_filter()
[Fact]
public void should_get_correct_result_when_filter_has_two_logical_filter()
{
var jsonRule = "{\r\n" +
" \"_or\": [\r\n" +
" {\r\n" +
" \"age\": {\r\n" +
" \"_gte\": 20" +
"\r\n" +
" }\r\n" +
" },\r\n" +
" {\r\n" +
" \"country\": {" +
"\r\n" +
" \"_eq\": \"P" +
"oland\",\r\n" +
" \"_in\": [\r" +
"\n" +
" \"Greece\"" +
",\r\n" +
" \"Norway\"" +
"\r\n" +
" ]\r\n" +
" }\r\n" +
" }\r\n" +
" ],\r\n" +
" \"_and\": [\r\n" +
" {\r\n" +
" \"age\": {\r\n" +
" \"_between\"" +
": [20, 30]\r\n" +
" }\r\n" +
" },\r\n" +
" {\r\n" +
" \"name\": {\r" +
"\n" +
" \"_starts_wi" +
"th\": \"test\"\r\n" +
" }\r\n" +
" }\r\n" +
" ]\r\n" +
"}";
var jsonRule = @"{
""_or"": [
{ ""age"": { ""_gte"": 20 } },
{ ""country"": { ""_eq"": ""Poland"", ""_in"": [ ""Greece"", ""Norway"" ] } }
],
""_and"": [
{ ""age"": { ""_between"": [20, 30] } },
{ ""name"": { ""_starts_with"": ""test"" } }
]
}";

var expected = PeopleList.Where(person =>
// or
Expand Down Expand Up @@ -111,4 +82,41 @@ public void should_get_correct_result_when_filtering_nested_object()

Assert.Equal(expected.Count, result.Count);
}

[Fact]
public void should_match_using_in_operator()
{
var jsonRule = "{ \"country\": { \"_in\": [\"Poland\", \"Greece\"] } }";

var expected = PeopleList.Where(person => new[] { "Poland", "Greece" }.Contains(person.Country)).ToList();
var f = new Filter<Person>(jsonRule);
var exp = FilterToLambdaParser.Parse(f);
var result = PeopleList.Where(exp.Compile()).ToList();

Assert.Equal(expected.Count, result.Count);
}

[Fact]
public void empty_in_array_should_match_no_items()
{
var jsonRule = "{ \"country\": { \"_in\": [] } }";

var f = new Filter<Person>(jsonRule);
var exp = FilterToLambdaParser.Parse(f);
var result = PeopleList.Where(exp.Compile()).ToList();

Assert.Empty(result);
}

[Fact]
public void empty_nin_array_should_match_all_items()
{
var jsonRule = "{ \"country\": { \"_nin\": [] } }";

var f = new Filter<Person>(jsonRule);
var exp = FilterToLambdaParser.Parse(f);
var result = PeopleList.Where(exp.Compile()).ToList();

Assert.Equal(PeopleList.Count, result.Count);
}
}
Loading