feat: Integrate LDropdown component for enhanced dropdown functionality in LSelect by iann460 · Pull Request #1280 · bccsa/luminary

iann460 · 2026-01-09T08:00:54Z

No description provided.

ivanslabbert · 2026-01-14T07:13:38Z

cms/package-lock.json

The package lock file should not change unless done as part of security patching

Seems to not be something that changes, github is incorrectly "recognising" it as changed. The code is actually just recognizing the last line as changed but from what I see it is not

ivanslabbert · 2026-01-14T07:14:45Z

cms/src/components/forms/LCombobox.vue

 const inputElement = ref<HTMLInputElement>();
 const comboboxParent = ref<HTMLElement>();
-const dropdown = ref<HTMLElement>();
+//const dropdown = ref<HTMLElement>();


Remove commented code

ivanslabbert · 2026-01-14T07:18:52Z

cms/src/components/forms/LCombobox.vue

+const focusInput = () => {
+    inputElement.value?.focus();
+};


if the function is only used once, it can be added inline in the template (@click="() => inputElement?.focus()")

MrDirkelz · 2026-01-15T09:17:24Z

cms/src/components/forms/LCombobox.vue

+/*onClickOutside(comboboxParent.value, () => {
    showDropdown.value = false;
-});
+});*/


Remove this commented out good. But good choice to remove duplicate functionality

MrDirkelz · 2026-01-15T09:18:06Z

cms/src/components/forms/LSelect.vue

Just revert LSelect.vue to main.

MrDirkelz · 2026-02-02T14:25:42Z

Dropdown not displaying options

Also some unused imports - and unused code left in

Is this also an LCombobox? Just check perhaps?

…ty in LSelect

…tionality and filter options

… handlers

…own closure

…pdown reference and updating click event

…Select comments

… selected option value handling

… existence

…tent component

…ove redundant checks

…tainability

…ole logs

…tion, and reset global language state in test utilities.

… in EditContent spec.

…tainability

…ole logs

…pdate several package versions for improved compatibility

…nd modal components

bell-johan

See comments @iann460

ivanslabbert · 2026-03-02T08:05:54Z

app/package-lock.json

An updated package-lock.json should not be committed if package.json did not change. Please revert change. (Remember to always use npm ci --install-links instead of npm install which will prevent making changes to packag-lock.json

ivanslabbert · 2026-03-02T08:13:58Z

package-lock.json

Remove changes to root folder package.json / package-lock.json

ivanslabbert · 2026-03-02T08:14:03Z

package.json

Remove changes to root folder package.json / package-lock.json

iann460 linked an issue Jan 9, 2026 that may be closed by this pull request

CMS: Use LDropdown for dropdowns in LCombobox component and Filter Options in ContentOverview #1210

Open

iann460 removed a link to an issue Jan 9, 2026

CMS: Use LDropdown for dropdowns in LCombobox component and Filter Options in ContentOverview #1210

Open

MrDirkelz assigned iann460 Jan 13, 2026

MrDirkelz linked an issue Jan 13, 2026 that may be closed by this pull request

CMS: Use LDropdown for dropdowns in LCombobox component and Filter Options in ContentOverview #1210

Open

iann460 force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from a125984 to 33e363f Compare January 13, 2026 06:47

ivanslabbert reviewed Jan 14, 2026

View reviewed changes

iann460 force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from 1558619 to 4f14ba9 Compare January 15, 2026 08:47

MrDirkelz force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch 3 times, most recently from 4f14ba9 to 20a8175 Compare January 15, 2026 09:02

MrDirkelz reviewed Jan 15, 2026

View reviewed changes

iann460 force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from 9a75b21 to b92e4cf Compare January 15, 2026 11:51

MrDirkelz force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from b92e4cf to 1045b9f Compare January 16, 2026 08:12

MrDirkelz force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from 1045b9f to b96b076 Compare January 23, 2026 08:15

MrDirkelz force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from 91c1670 to 1ae4292 Compare February 2, 2026 14:11

iann460 force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from 6bf2d86 to 3f41b14 Compare February 5, 2026 11:57

MrDirkelz force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch 3 times, most recently from bcfc56a to 7c1ca85 Compare February 12, 2026 09:34

iann460 force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from 2441e02 to 282ba0b Compare February 19, 2026 10:01

MrDirkelz and others added 9 commits February 25, 2026 13:18

feat: Integrate LDropdown component for enhanced dropdown functionali…

cdaec3d

…ty in LSelect

feat: Use LDropdown component in LCombobox for improved dropdown func…

5131951

…tionality and filter options

fix: Correctly reference rootRef and comboboxParent in onClickOutside…

afb3d7a

… handlers

Implement feature X to enhance user experience and fix bug Y in module Z

16fc672

fix: Comment out onClickOutside handler in LCombobox to prevent dropd…

6e63eeb

…own closure

refactor: Simplify focus handling in LCombobox by removing unused dro…

b58d484

…pdown reference and updating click event

fix: Restore onClickOutside functionality in LCombobox and clean up L…

cade6ec

…Select comments

fix: Update LCombobox tests to check visibility of options and adjust…

b8b62ad

… selected option value handling

test: Update language selector checks to verify visibility instead of…

2923f29

… existence

ChrisTouo and others added 19 commits February 25, 2026 13:18

Refactor: Increasing a timeout

d86ad50

Refactor: Test modified

7d59271

Test

948d9d3

Test

c6f9170

test: Add console log to debug language selector rendering in EditCon…

232ad00

…tent component

test: Update language selector test to verify component count and rem…

8854429

…ove redundant checks

test: Refactor language selector test to improve readability and main…

6be8e7d

…tainability

test: Simplify language selector rendering test in EditContent component

98988d7

test: Update language selector test to use dynamic ID and remove cons…

8153bf5

…ole logs

refactor: Remove unused dropdown toggle functions in LCombobox

811f6b4

chore: Add package-lock.json for dependency management

42d45e9

test: mock URL.createObjectURL for tests, await language initializa…

fbf1da4

…tion, and reset global language state in test utilities.

test: add wait condition to verify translatableLanguagesAsRef updates…

35203c2

… in EditContent spec.

Implement feature X to enhance user experience and fix bug Y in module Z

3df578e

test: Refactor language selector test to improve readability and main…

687b647

…tainability

test: Simplify language selector rendering test in EditContent component

9d16a4a

test: Update language selector test to use dynamic ID and remove cons…

fe5ed14

…ole logs

chore: Update package-lock.json to add new dependency 'rte-vue' and u…

482fd7e

…pdate several package versions for improved compatibility

feat: Update package dependencies to include baseline-browser-mapping

15d3939

iann460 force-pushed the 1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview branch from a11b4b4 to 15d3939 Compare February 25, 2026 11:18

MrDirkelz added 2 commits February 25, 2026 14:19

refactor: Enhance layout and styling in dialog, dropdown, combobox, a…

f4bfdee

…nd modal components

fix: Correct typo in event binding for AddGroupAclButton component

3df2d0b

ivanslabbert requested a review from johan-bell February 27, 2026 07:05

bell-johan reviewed Feb 27, 2026

View reviewed changes

ivanslabbert reviewed Mar 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Integrate LDropdown component for enhanced dropdown functionality in LSelect#1280

feat: Integrate LDropdown component for enhanced dropdown functionality in LSelect#1280
iann460 wants to merge 30 commits intomainfrom
1210-cms-use-ldropdown-for-dropdowns-in-lcombobox-component-and-filter-options-in-contentoverview

iann460 commented Jan 9, 2026

Uh oh!

ivanslabbert Jan 14, 2026

Uh oh!

MrDirkelz Jan 15, 2026

Uh oh!

ivanslabbert Jan 14, 2026

Uh oh!

ivanslabbert Jan 14, 2026

Uh oh!

MrDirkelz Jan 15, 2026

Uh oh!

MrDirkelz Jan 15, 2026

Uh oh!

MrDirkelz commented Feb 2, 2026

Uh oh!

bell-johan left a comment

Uh oh!

ivanslabbert Mar 2, 2026

Uh oh!

ivanslabbert Mar 2, 2026

Uh oh!

ivanslabbert Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

iann460 commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MrDirkelz commented Feb 2, 2026

Uh oh!

bell-johan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants