31096 - Skip Event Not Completed For Migration #3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| and (end_event_id is null or end_event_id >= {event_id}) | ||
| and corp_name_typ_cd in ('CO', 'NB') | ||
| order by start_event_id desc | ||
| limit 1) = null |
Collaborator
There was a problem hiding this comment.
Suggested change
| limit 1) = null | |
| limit 1) is null |
vysakh-menon-aot
approved these changes
Dec 22, 2025
Collaborator
vysakh-menon-aot
left a comment
vysakh-menon-aot
left a comment
There was a problem hiding this comment.
I cannot visualize the impact of this. please test with different scenario to make sure its not missing any data
argush3
reviewed
Jan 12, 2026
Comment on lines
-710
to
+715
| left outer join corp_name cn_old on e.event_id = cn_old.end_event_id and cn_old.corp_name_typ_cd in ('CO', 'NB') | ||
| left outer join corp_name cn_new on e.event_id = cn_new.start_event_id and cn_new.corp_name_typ_cd in ('CO', 'NB') | ||
| left outer join corp_name cn_old on e.event_id = cn_old.end_event_id | ||
| left outer join corp_name cn_new on e.event_id = cn_new.start_event_id | ||
| left outer join cont_out co on co.start_event_id = e.event_id | ||
| where 1 = 1 | ||
| and e.corp_num = '{corp_num}' | ||
| and not (cn_old.corp_name is null AND cn_new.corp_name is not null and cn_new.corp_name_typ_cd in ('CO', 'NB')) |
Collaborator
There was a problem hiding this comment.
Don't think this works.
I just tested this code locally and I still see the conversion name change for name change type NO being migrated into the filings table.
local testing results:
I think the solution should be:
- Keep the left outer joins as is. i.e continue filtering on ('CO', 'NB')
- Add the where clause of
and not (e.event_type_cd = 'CONVNC' and cn_old.corp_name is null and cn_new.corp_name is null). I think this should work because the joins where name types that are not CO or NB will now be null. I haven't tested this so you'll need to see if it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#31096
Description of changes:
Skip Events which are not completed
event 1 -> event2
event2 -> null [skip] (currently in name change its returning null -> null )
event 2 -> event3
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).