30660 - Validate Auto Detect Completing Party #4022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajandeep98
requested review from
loneil,
severinbeauvais and
vysakh-menon-aot
| phone = user_contacts[0].get("phone", "") | ||
| elif user_data.get("phone"): | ||
| # IDIR | ||
| phone = user_data.get("phone", "") |
Collaborator
There was a problem hiding this comment.
FYI, phone may not be a property of the @me response.
| "streetAdditional": org_contact.get("streetAdditional", ""), | ||
| "delieveryInstructions": org_contact.get("deliveryInstructions", "") | ||
| "streetAdditional": mailing_address.get("streetAdditional", ""), | ||
| "delieveryInstructions": mailing_address.get("deliveryInstructions", "") |
Collaborator
There was a problem hiding this comment.
Typo.
Also, I think deliveryInstructions is not a property of the orgs response. oops, it is
severinbeauvais
approved these changes
Jan 22, 2026
Collaborator
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
LGTM except for typo.
loneil
approved these changes
Jan 23, 2026
vysakh-menon-aot
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#30660
Description of changes:
Completing Party:
User info + Org Info
User info
org info
mailing address
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).