Filer - Receiver/Liquidator DRS publishing #4035
Conversation
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
| "consumerDocumentId": document_id, | ||
| "consumerIdentifier": business.identifier, | ||
| "consumerFilingType": filing.filing_type, | ||
| "consumerReferenceId": str(filing.id), |
There was a problem hiding this comment.
Note: if using the filings.id instead of the filings.transaction_id it should match what is submitted with the coming DRS integration to save filing reports so that the document is associated with the right filing in the ledger (when a filing has a document and reports).
There was a problem hiding this comment.
Verified we use the filing.id when saving filing reports (this is behind a FF but when flipped it will end up using this to create the DRS record): https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/reports/report.py#L134
|
Can you update |
doug-lovett
left a comment
doug-lovett
left a comment
There was a problem hiding this comment.
Looks great, and I know it works. Just the one comment on using filings.id or filings.transaction_id to identify the filing.
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
3 participants
Issue #: /bcgov/entity#31316
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).