Skip to content

[MDS-6728] Still show disabled definitions with existing reports#3853

Merged
asinn134 merged 4 commits intodevelopfrom
mds-6728-still-show-disabled-definitions-with-existing-reports
Mar 6, 2026
Merged

[MDS-6728] Still show disabled definitions with existing reports#3853
asinn134 merged 4 commits intodevelopfrom
mds-6728-still-show-disabled-definitions-with-existing-reports

Conversation

@asinn134
Copy link
Collaborator

@asinn134 asinn134 commented Mar 5, 2026

Objective

MDS-6728

  • Previously added some filtering around mine report definition where if the definition is not active we would filter it out. The problem with this is there are definitions that are not active but still reports that may have been submitted or requested in the past. We still want to allow the user to see/find these.

  • Adjusted mine report definition filtering where if the definition is not active but there exists active mine reports associated with the definition we still show it in our report filter's report name dropdown option.

image image

const resp = await CustomAxios({
errorToastMessage: "Failed to load compliance reports",
}).get(`${ENVIRONMENT.apiUrl}${API.MINE_REPORT_DEFINITIONS({ ...searchParams, active_ind: [true] })}`, headers);
}).get(`${ENVIRONMENT.apiUrl}${API.MINE_REPORT_DEFINITIONS(searchParams ?? {})}`, headers);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing it back to what it was before

}

# Base query; ordering is applied via ReportFilterHelper
query = (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing it back to what it was before

'region': request.args.getlist('region', type=str),
}

query = (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing it back to what it was before

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@asinn134 asinn134 merged commit 73c7edc into develop Mar 6, 2026
20 checks passed
@asinn134 asinn134 deleted the mds-6728-still-show-disabled-definitions-with-existing-reports branch March 6, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants