ci: standardize workflows and chart patterns to match org playbook - #17
Merged
Conversation
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes CI/CD workflows, Helm chart templates, Dockerfile, and supporting config to match the bcit-tlu org playbook patterns, using
qcon-apias the gold-standard reference.Changes:
.github/workflows/build-and-push-app.yaml.inactiveAGENTS.md— setup commands, code style, project structure, CI/CD, and deployment info following hriv structure|| true+grepto|| { echo; exit 1; }with tolerant digest parse; shell-safeenv:blocks for login steps; reduced comment verbosityFORCE_JAVASCRIPT_ACTIONS_TO_NODE24; shell-safeenv:blocks; dynamicCHART_NAMEviayq; sign step uses env vars instead of inline expressionsTAGSvariable nameFORCE_JAVASCRIPT_ACTIONS_TO_NODE24; reduced verbose comments to single-linersFORCE_JAVASCRIPT_ACTIONS_TO_NODE24; condensed failure explainer comment to match qcon-api{{- if $aff }}to{{- if ne (toJson $aff) "{}" }}##comment markers changed to## x-release-please-versionannotation toversion:linepackage-lock.jsonentries ($.versionand$.packages[''].version) to extra-filesNot changed: app code, build logic, CI triggers/conditions, release-please version tracking mechanism,
package.jsonin extra-files, deployment behavior, job dependencies.Review & Testing Checklist for Human
ci.yamlandhelm-publish.yamlmatches qcon-api exactly (|| { echo "${PUSH_OUT}"; exit 1; })FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueis present in all 5 workflow filesactions/checkout@v6is used everywhere (was already v6, confirmed preserved)release-please-config.jsonextra-files include bothpackage-lock.jsonjsonpath entriesversion:line now has# x-release-please-versionannotationhelm template test charts/should produce valid YAML with no emptyaffinity:blockNotes
.psd,.docx,.png) showed CRLF→LF working-tree changes from.gitattributes— these were intentionally excluded from this commitTAGSvariable name inrelease-retag.yamlwas kept as-is per instructions (qcon-api usesTAG_ARGS)Link to Devin session: https://app.devin.ai/sessions/b843505ded5e4091a30155550bc6f44f
Requested by: @kphunter