Skip to content

fix: replace hardcoded NGINX_DNS_RESOLVER with NGINX_LOCAL_RESOLVERS #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visoedhwa merged 1 commit into from
Jul 29, 2026
Merged

fix: replace hardcoded NGINX_DNS_RESOLVER with NGINX_LOCAL_RESOLVERS #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/frontend/files/default.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ server {
# backend Service DNS at request time, so it survives backend pod
# restarts / re-scheduling in Kubernetes.
location /api/ {
resolver ${NGINX_DNS_RESOLVER} valid=10s;
resolver ${NGINX_LOCAL_RESOLVERS} valid=10s;
set $backend "${BACKEND_URL}";

# Strip the /api prefix before proxying (backend serves at root).
Expand Down
2 changes: 0 additions & 2 deletions charts/frontend/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ spec:
# explicit override, otherwise the cluster-internal Service FQDN.
- name: BACKEND_URL
value: {{ include "dialog-frontend.backendUrl" . | quote }}
- name: NGINX_DNS_RESOLVER
value: {{ .Values.env.NGINX_DNS_RESOLVER | quote }}
volumeMounts:
# Shadow the image's baked-in template with the ConfigMap so the
# upstream can change without an image rebuild.
Expand Down
3 changes: 0 additions & 3 deletions charts/frontend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ env:
# Explicit override for the nginx upstream. Leave empty to auto-build
# the backend Service FQDN (see dialog-frontend.backendUrl helper).
BACKEND_URL: ""
# nginx DNS resolver used for runtime re-resolution of the backend
# Service. Defaults to the Kubernetes cluster DNS service address.
NGINX_DNS_RESOLVER: "kube-dns.kube-system.svc.cluster.local"

ingress:
enabled: false
Expand Down
2 changes: 1 addition & 1 deletion frontend/default.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ server {
# backend Service DNS at request time, so it survives backend pod
# restarts / re-scheduling in Kubernetes.
location /api/ {
resolver ${NGINX_DNS_RESOLVER} valid=10s;
resolver ${NGINX_LOCAL_RESOLVERS} valid=10s;
set $backend "${BACKEND_URL}";

# Strip the /api prefix before proxying (backend serves at root).
Expand Down
2 changes: 1 addition & 1 deletion values-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ llm:
baseUrl: "https://ollama.com"
# Create out-of-band, then reference it (keys: ollama-api-key,
# azure-openai-api-key). Leave empty to let the chart create an empty Secret.
existingSecret: dialog-llm
existingSecret: llm-credentials

gateway:
enabled: true
Expand Down
Loading