chore(release): remove graduation overrides and vestigial component - #13
Merged
Merged
Conversation
Follow-up to #12 / #9. Two related cleanups: 1. Remove the temporary graduation overrides that forced release-please to cut a clean '0.3.0' instead of '0.3.0-rc': - 'release-as': '0.3.0' - 'prerelease': false With '0.3.0' now on main, leaving these in would make release-please keep proposing 0.3.0 on every run (no-op but noisy) and block the next normal rc bump. 2. Remove the vestigial 'component': 'haproxy-operator' entry. Under strict-D this repo uses 'include-component-in-tag': false, so tags are 'vX.Y.Z' (no component prefix). The component field was a holdover from pre-strict-D (when the tag was 'haproxy-operator-v*'). With 'separate-pull-requests': false + no custom title pattern, release-please renders the release PR title as 'chore: release main' — which contains no ${component} token. On the post-merge run of PR #9 this caused release-please to log 'PR component: undefined does not match configured component: haproxy-operator' while building the release for path '.', and abort without creating the v0.3.0 tag or GitHub release. The follow-up 'dispatch-publish' step was therefore skipped, so the 0.3.0 image/chart were never published and the moving 'stable'/'latest' OCI pointers were not moved. Dropping the single-package component brings the config in line with a normal single-component strict-D repo (compare tech-ops-docs) and lets release-please parse 'chore: release main' correctly on future releases. Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related cleanups to
release-please-config.jsonas a follow-up to #9 / #12.1. Remove the temporary graduation overrides
release-as: "0.3.0"prerelease: falseThese were added by #12 to force release-please to cut a clean-stable
0.3.0on the PR #9 run (instead of0.3.0-rc). With0.3.0now on main, leaving them in would make release-please keep proposing0.3.0on every run (no-op but noisy) and block the next normal rc bump.2. Remove the vestigial
component: "haproxy-operator"entryThis was a holdover from pre-strict-D, when the repo's tag format was
haproxy-operator-v*. After #8 adopted strict-D,include-component-in-tagflipped tofalse— tags should now be plainvX.Y.Z— but thecomponentfield was left in place.Why this matters: with
separate-pull-requests: falseand no custompull-request-title-pattern, release-please renders the release PR title aschore: release main— which has no${component}token. On the post-merge run for PR #9, release-please logged:while building the release for path
., and aborted without creating thev0.3.0tag or GitHub release. The follow-updispatch-publishstep inrelease-please.yamlwas therefore skipped, so the0.3.0image/chart were never published and the movingstable/latestOCI pointers were not moved.Dropping the single-package
componentbrings the config in line with a normal single-component strict-D repo (comparetechnical-operations-documentation) and lets release-please parsechore: release maincorrectly on future releases.Relevant config post-change:
{ "include-component-in-tag": false, "separate-pull-requests": false, "versioning": "prerelease", "prerelease": true, "prerelease-type": "rc", "packages": { ".": { "release-type": "simple", "extra-files": [ { "type": "generic", "path": "charts/haproxy-operator/Chart.yaml" } ] } } }Expected effect once merged
autorelease: pending. With the title-parsing mismatch resolved, release-please should now create thev0.3.0git tag on merge commita1d1058+ the corresponding GitHub release.release-please.yamlre-dispatchesci.yamlatrefs/tags/v0.3.0, which publishes the immutable:0.3.0image + chart and moves the:stable/:latestOCI pointers (since0.3.0is now the highest stable SemVer for this repo — the only prior tag is the legacyhaproxy-operator-v0.2.0, which is inert under the current tag format).If for any reason release-please still doesn't tag
v0.3.0on this run, the fallback is a manual annotated tag ona1d1058+ matching GitHub release — which triggers the samedispatch-publishpath.Review & Testing Checklist for Human
component: "haproxy-operator"(this changes how release-please groups path.in logs/release titles; tags are unaffected becauseinclude-component-in-tagis alreadyfalse).v0.3.0on commita1d1058+ a GitHub release. If it does, also confirm the follow-up CI tag run publishes:0.3.0+ moves:stable/:lateston bothghcr.io/bcit-tlu/haproxy-operator/haproxy-operatorandghcr.io/bcit-tlu/haproxy-operator/charts/haproxy-operator.v0.3.0tag ona1d1058) can be cut.Notes
No code changes — only
release-please-config.json. CI runs that gate on Go / Helm changes are unaffected.Link to Devin session: https://app.devin.ai/sessions/8688f4d14a8f46839fd8ede494e61166
Requested by: @kphunter