chore: remove legacy per-entity reorder endpoints and SortableTileGrid fallback - #1000
Open
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…d fallback Removes PUT /api/categories/reorder and PUT /api/images/reorder, their request schemas, the reorderCategories/reorderImages API wrappers, and the non-coordinator fallback persistence path in SortableTileGrid (the tileOrdering prop is now required). PUT /api/tile-order via the shared coordinator is the sole ordering write path. Migrates tests to the coordinator-only contract and updates the ordering/telemetry docs. Closes #998. Part of epic #975. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…y reorder code Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #998 (final cleanup sub-issue of epic #975). With Browse (#995–#997) and Manage Categories (#999) both persisting ordering through the shared coordinator and
PUT /api/tile-order, the deprecated dual-write ordering path is deleted:PUT /api/categories/reorderandPUT /api/images/reorderroutes removed, along withCategoryReorderRequest/ImageReorderRequestschemas and their per-endpoint telemetry glue.PUT /api/tile-order(single transaction, set-based, CAS-revisioned) is now the only ordering write path.reorderCategories/reorderImageswrappers removed fromapi.ts; the non-coordinator fallback persistence path inSortableTileGridis gone and thetileOrderingprop is now required — every accepted drop isreportOrder-ed to the coordinator, which owns queueing/coalescing/conflicts:SortableTileGrid.test.tsx,SortableTileGridReorderRegression.test.tsx, backend router/telemetry/fixture tests); the obsoleteSortableTileGridReorderTelemetry.test.tsx(legacy grid-owned lifecycle telemetry) is deleted — coordinator telemetry is covered intileOrdering.test.ts.tile-ordering.md,reorder-telemetry.md, anddrag-and-drop.mdupdated; move-vs-reorder dispatch contract unchanged.The
ignored/abandonedlifecycle states remain in the telemetry vocabulary (historical dashboards) but are no longer emitted.Validation: backend
poetry run pytest(959 passed), frontendnpm test(1372 passed), build, format:check, lint (only the pre-existingCanvasOverlay.tsxreact-refresh error).Link to Devin session: https://app.devin.ai/sessions/414754bd88374dc693f47100ac269e78