fix: use correct release-please output key for root package dispatch - #4
Merged
Merged
Conversation
The release-please-action v4 outputs plain keys (e.g. 'tag_name') for
packages at root path '.', NOT path-prefixed keys ('.--tag_name').
The incorrect key caused dispatch-publish to always receive an empty
TAG, silently skipping the helm-publish and release-retag dispatches.
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
dispatch-publishjob which uses the wrong output key ('.--tag_name'instead of'tag_name') to read the release tag. The release-please-action v4 source outputs plain keys for root path.packages, so'.--tag_name'always resolves to empty, silently skippinghelm-publishandrelease-retagdispatch.Same fix applied across all affected bcit-tlu repos (see conversion-guide PR #15 for full root cause analysis).
Review & Testing Checklist for Human
helm-publish.yamlwithtag_name=v1.1.6andrelease-retag.yamlwithtag_name=v1.1.6to publish missing clean tagsNotes
Currently only RC chart tags exist in GHCR — no clean semver release tags. The stable overlay will not work until clean tags are published.
Link to Devin session: https://app.devin.ai/sessions/90351d31211c4d5fa00523df61bc4b90
Requested by: @kphunter