ci: standardize workflows and chart patterns to match org playbook - #5
Merged
Conversation
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize workflows, Helm chart, and supporting files to match the
bcit-tlu/qcon-apireference and org playbook conventions.Deletions:
.github/workflows/build-and-push-app.yaml.inactive(stale legacy workflow)VERSIONfile (version tracked solely via.release-please-manifest.json+Chart.yaml)Workflow changes (all 5 workflows):
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: truetopr-title-lint.yaml,release-please.yaml,helm-publish.yaml(already present inci.yamlandrelease-retag.yaml)actions/checkout@v6across all workflows|| true+grephelm push error guard with|| { echo "${PUSH_OUT}"; exit 1; }inci.yamlandhelm-publish.yamlawk 'tolower($1)=="digest:"') instead of strictawk '/^Digest:/'yqinstead ofawkfor chart name extraction${{ }}) intoenv:blocks for shell safetyrelease-retag.yamlsign step:if: steps.parse.outputs.match == 'true' && steps.retag.outputs.digest != ''TAGSvariable in retag stepHelm chart:
deployment.yaml:{{- if $aff }}→{{- if ne (toJson $aff) "{}" }}(correctly handles empty dict)Chart.yaml: Add# x-release-please-versionannotation toversion:linevalues.yaml: Reduce verbose comment block forzoneAntiAffinityOther:
Dockerfile:##→#for stage commentsAGENTS.md: Add helm lint/validate commands, CI/CD section with version tracking info, MPL-2.0 license mentionReview & Testing Checklist for Human
helm-publishinci.yamlcorrectly moves OCI_BASE and IMAGE_BASE intoenv:block — ensure no variable resolution issues at GHA evaluation timeTAGSbash array pattern inrelease-retag.yamlworks correctly for the retag step (changed from string concatenation to proper array)tolower) matches actualhelm pushoutput format on your runner versionNotes
release-please-config.jsonalready had noversion-fileentry — no changes needed thereChart.yamlversionwas0.1.0(behind manifest0.2.0); the# x-release-please-versionannotation was added so release-please will bump it going forwardLink to Devin session: https://app.devin.ai/sessions/cb8f57d6c8504a13961a5ecf6db61af1
Requested by: @kphunter