Skip to content

ci: standardize workflows and chart patterns to match org playbook - #6

Merged
kphunter merged 1 commit into
mainfrom
devin/1779662939-standardize-patterns
May 25, 2026
Merged

ci: standardize workflows and chart patterns to match org playbook#6
kphunter merged 1 commit into
mainfrom
devin/1779662939-standardize-patterns

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Aligns qcon-guide's workflows and docs with the qcon-api reference implementation. Most patterns were already standardized from a prior pass — this PR addresses the remaining gaps:

  • pr-title-lint.yaml: Replaced verbose sticky-comment failure message with qcon-api's concise version (shorter heading, bullet-style examples, one-liner edit hint).
  • release-please.yaml: Added the 2-line comment above dispatch-publish explaining why explicit dispatch is needed (GITHUB_TOKEN releases don't trigger downstream workflows).
  • AGENTS.md: Removed duplicate CI/publish bullets from Deployment section (already covered in CI/CD section).

All other playbook patterns (FORCE_JAVASCRIPT_ACTIONS_TO_NODE24, checkout@v6, helm push error guard, tolerant digest parse, yq chart name extraction, shell-safe GHA expressions, digest guard on sign steps, Chart.yaml annotations, release-please-config.json, affinity conditional) were already matching the reference.

Review & Testing Checklist for Human

  • Verify the pr-title-lint sticky comment renders correctly on a failing PR (formatting, emoji, code blocks)
  • Confirm release-please dispatch still triggers helm-publish and release-retag on next release

Notes

  • Helm lint passes: 1 chart linted, 0 failed
  • Kubeconform passes: 3 resources valid, 0 invalid
  • No functional workflow changes — only comments and documentation

Link to Devin session: https://app.devin.ai/sessions/ee3ef5b17ac74a99be13392c18df2f5c
Requested by: @kphunter


Open in Devin Review

Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@kphunter
kphunter merged commit ef3123a into main May 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant