ci: standardize workflows and chart patterns to match org playbook - #6
Merged
Merged
Conversation
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns qcon-guide's workflows and docs with the qcon-api reference implementation. Most patterns were already standardized from a prior pass — this PR addresses the remaining gaps:
dispatch-publishexplaining why explicit dispatch is needed (GITHUB_TOKEN releases don't trigger downstream workflows).All other playbook patterns (FORCE_JAVASCRIPT_ACTIONS_TO_NODE24, checkout@v6, helm push error guard, tolerant digest parse, yq chart name extraction, shell-safe GHA expressions, digest guard on sign steps, Chart.yaml annotations, release-please-config.json, affinity conditional) were already matching the reference.
Review & Testing Checklist for Human
Notes
Link to Devin session: https://app.devin.ai/sessions/ee3ef5b17ac74a99be13392c18df2f5c
Requested by: @kphunter