Implement Model Student app via red-green TDD#3
Open
bclinkinbeard wants to merge 5 commits intomainfrom
Open
Conversation
Built the complete multi-page ML experimentation web app following the red-green TDD cycle specified in PLAN.md. Each module was implemented by first writing failing tests, then writing minimal code to pass them. - Shared libraries: model-loader (lazy-load + caching) and model-status (pure state machine) with 15 unit tests - Sentiment Analysis page: formatSentimentResult, isInputValid with 11 unit tests + 9 E2E tests - Image Classification page: formatClassificationResults, isValidImageFile with 16 unit tests + 7 E2E tests - Text Summarization page: computeSummaryStats, isTooShort, loadWithFallback with 14 unit tests + 8 E2E tests - Landing page with card grid linking to all experiments + 8 E2E tests - Full design system in app.css with dark mode, WCAG AA contrast compliance - Playwright E2E testing with pipeline mocking via globalThis injection - All 56 unit tests and 64 E2E tests (desktop + mobile) passing - Production build verified https://claude.ai/code/session_016SHnm5XvjjWkf4URWAEPe1
- Add vercel.json with buildCommand that runs unit tests before building, so Vercel deploys fail if tests fail - Add Husky pre-push hook that runs the full test suite (unit + E2E) before allowing git push, catching failures at the source - Add husky as devDependency with prepare script https://claude.ai/code/session_01YC4pvbBFiAPMZEAKuJ14bK
E2E tests require browser infrastructure (Playwright browsers) that may not be available in all dev environments. Unit tests are fast and catch logic regressions. E2E coverage is enforced at the Vercel build step. https://claude.ai/code/session_01YC4pvbBFiAPMZEAKuJ14bK
The crash: computeSummaryStats() called countWords() on undefined/null summaryText, hitting undefined.trim() → TypeError. The E2E tests mocked the pipeline with perfect data so they never exercised this path. Fix: add null guard in countWords() so undefined/null input returns 0 instead of crashing. Tests added (red→green TDD): - computeSummaryStats with undefined/null summaryText and originalText - formatSentimentResult with empty array and undefined input (documents that these throw, caught by the wiring layer's try-catch) CI: add GitHub Actions workflow that installs Playwright browsers (--with-deps chromium) and runs the full test suite (unit + E2E) plus build on every push/PR to main. https://claude.ai/code/session_01YC4pvbBFiAPMZEAKuJ14bK
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The summarization page crashes at runtime when used with real models. Remove the entire feature — page, logic, tests, and all references — leaving only the two working experiments (Sentiment Analysis and Image Classification). https://claude.ai/code/session_01YC4pvbBFiAPMZEAKuJ14bK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built the complete multi-page ML experimentation web app following the
red-green TDD cycle specified in PLAN.md. Each module was implemented by
first writing failing tests, then writing minimal code to pass them.
(pure state machine) with 15 unit tests
unit tests + 9 E2E tests
with 16 unit tests + 7 E2E tests
with 14 unit tests + 8 E2E tests
https://claude.ai/code/session_016SHnm5XvjjWkf4URWAEPe1