Skip to content

feat: add pwa shortcuts and share target#25

Open
bclinkinbeard wants to merge 1 commit intomainfrom
codex/pwa-entry-points-pr
Open

feat: add pwa shortcuts and share target#25
bclinkinbeard wants to merge 1 commit intomainfrom
codex/pwa-entry-points-pr

Conversation

@bclinkinbeard
Copy link
Copy Markdown
Owner

Summary

  • add manifest shortcuts for one-tap record and text entry launches
  • add share target support that turns shared text or URLs into notes in the default list
  • make the service worker treat launch URLs as app-shell navigations so shortcuts still work offline

Testing

  • npm test
  • npm run build

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
voice-notes Ready Ready Preview Mar 26, 2026 8:20pm

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcfe6c4bb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread public/manifest.json
],
"share_target": {
"action": "./?share-target=1",
"method": "GET",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use POST share target to avoid truncating shared content

Declaring the share target with "method": "GET" puts the shared payload into the URL query string, which is subject to browser/OS URL-length limits; longer shares (for example selected article text) can be truncated or rejected before parseLaunchAction runs, causing partial or missing notes with no user-visible error. This is user-impacting for common share flows and should use a POST share target path instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant