feat: add pwa shortcuts and share target#25
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcfe6c4bb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ], | ||
| "share_target": { | ||
| "action": "./?share-target=1", | ||
| "method": "GET", |
There was a problem hiding this comment.
Use POST share target to avoid truncating shared content
Declaring the share target with "method": "GET" puts the shared payload into the URL query string, which is subject to browser/OS URL-length limits; longer shares (for example selected article text) can be truncated or rejected before parseLaunchAction runs, causing partial or missing notes with no user-visible error. This is user-impacting for common share flows and should use a POST share target path instead.
Useful? React with 👍 / 👎.
Summary
Testing