fix(redshift): handle boolean fields and quoted text in build_json - #94
Merged
Merged
Conversation
Redshift's string-concatenation JSON builder had two bugs: - Boolean fields cast to varchar yield `t`/`f`, not `true`/`false` - Text fields containing `"` or `\` produce invalid JSON Fix branches on data_types[feature] type: booleans use CASE WHEN IS TRUE/FALSE, text escapes `\` then `"` via replace(). Closes bcodell#90 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Owner
|
@redthor nicely done! I think CI failed due to missing env vars. Given the scope of these changes, and given that we don't have proper CI for redshift (too expensive to maintain a cluster for an OSS project), I'm going to merge and cut a new patch version. Thanks for contributing! Let me know if you run into anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redshift's string-concatenation JSON builder had two bugs:
t/f, nottrue/false"or\produce invalid JSONFix branches on data_types[feature] type: booleans use CASE WHEN IS TRUE/FALSE, text escapes
\then"via replace().Closes #90