Open
Conversation
tynes
reviewed
Aug 14, 2018
package.json
Outdated
| "istanbul": "^1.1.0-alpha.1", | ||
| "jsdoc": "^3.5.5", | ||
| "mocha": "^5.2.0", | ||
| "mockdate": "^2.0.2", |
Member
There was a problem hiding this comment.
I like how mockdate has no dependencies itself, but adding dependencies to this project will make it very difficult to have your PR accepted. Would it be easy to write the test without adding the dependency?
Member
|
Also see here: http://bcoin.io/api-docs/index.html#get-server-info |
Contributor
Author
|
Thank you for the feedback! I understand the concern about adding an additional dependency. Uptime seems to always be Uptime isn't covered by the test that covers the server info request. Date mock could also benefit that and other time-related stuff I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51.
I am playing with bcash and thought that this issue would be a nice intro into the codebase.
Depends on the related pull bcoin-org/bclient#14 to pass the test.