http: use Address for bulk tx and utxo reads#93
Open
boymanjor wants to merge 2 commits intobcoin-org:masterfrom
boymanjor:address-fix
Open
http: use Address for bulk tx and utxo reads#93boymanjor wants to merge 2 commits intobcoin-org:masterfrom boymanjor:address-fix
boymanjor wants to merge 2 commits intobcoin-org:masterfrom
boymanjor:address-fix
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=========================================
- Coverage 55.23% 55.2% -0.03%
=========================================
Files 109 109
Lines 27039 27047 +8
Branches 4472 4472
=========================================
- Hits 14934 14932 -2
- Misses 12105 12115 +10
Continue to review full report at Codecov.
|
Contributor
|
Ditto a comment at bcoin-org/bcoin#612 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixed endpoints are being considered for deprecation.
For now, this commit adds a warning message to the logs
and a TODO to deprecate once the necessary functionality
is added to the wallet API.