Improve error message on missing rpc arguments#19
Open
dagurval wants to merge 1 commit intobcoin-org:masterfrom
Open
Improve error message on missing rpc arguments#19dagurval wants to merge 1 commit intobcoin-org:masterfrom
dagurval wants to merge 1 commit intobcoin-org:masterfrom
Conversation
Shows usage instead of assertion error
Author
|
Before: After: |
Member
|
This doesn't look quite right, a bad And an older approach not merged yet: bcoin-org/bcoin#550 |
Author
|
I think that's a separate issue. This PR is for letting the user know that he used the cli interface incorrectly (missing arguments). It's an improvement over asserting. I do agree that |
Member
|
I hear ya, but I think the best UX is providing the user with the list of possible arguments that could be missing. See #20 which in the case of a missing rpc method, will instead call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows usage instead of assertion error.