Makefile: scope TCC-stable signing to Debug only#15
Merged
Conversation
Follow-up to #14. The stable Apple Development signature is only needed for the debug builds launched repeatedly during development; Release must stay ad-hoc. A personal Apple Development cert is a development identity (expires, not valid for distribution), and both shipping paths re-sign ad-hoc anyway (install.sh `codesign --sign -`; release.yml runs on a runner with no cert). Previously `make build CONFIG=Release` locally signed with the dev cert and was then immediately re-signed ad-hoc by install.sh — a wasted step that also briefly put the personal identity on a Release artifact. Now: - Debug build -> dev cert when available (test target too, always Debug) - Release build -> always ad-hoc ("-") - CI (any config) -> ad-hoc, unchanged Verified: Debug build is Apple Development signed, Release build is ad-hoc. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14, in response to review: release distributions should never carry the personal Apple Development cert, even transiently.
Change
Scope the stable dev-cert signature to Debug builds only:
testtarget, which always builds Debug)."-"(equivalent to the project.yml default).Why
A personal Apple Development cert is a development identity — it expires and isn't valid for distribution. Both shipping paths already re-sign ad-hoc regardless (
install.shdoescodesign --sign -;release.ymlruns on a runner with no cert), so#14was signing local Release builds with the dev cert only to have it immediately overwritten. This removes that wasted/confusing step.Verified
make build(Debug) →Authority=Apple Development ...,TeamIdentifier=QJXKM5Q4WH.make build CONFIG=Release→Signature=adhoc,TeamIdentifier=not set.🤖 Generated with Claude Code