Fix unfiltered select-all delete in admin error logs

[bd73-com]

Summary

Fixes a bug where clicking "Select all" then "Delete" on the admin error logs page with no level/source filter active showed a blocking "Filter required" toast instead of performing the deletion. The fix falls back to sending the visible log entry IDs directly when no filter is active, while still using the more efficient filter-based bulk delete path when filters are set.

Changes

Bug fix (client/src/pages/AdminErrors.tsx):

• Removed the "Filter required" toast that blocked unfiltered select-all deletion
• When no filter is active, sends visible log IDs via the ids-based delete path instead of requiring the filters-based path
• Imported and delegated to the new buildBatchDeletePayload utility

Refactor (client/src/pages/adminErrorsUtils.ts):

• Extracted batch-delete payload construction into a pure, testable function buildBatchDeletePayload
• Handles 4 code paths: no selection, individual selection, selectAll+filters, selectAll+no-filters

UX improvement (client/src/pages/AdminErrors.tsx):

• Changed "All matching entries selected" → "All N visible entries selected" in the select-all checkbox label
• Changed "All matching entries" → "N visible entries" in the floating action bar count
• Prevents admins from thinking they're deleting all entries in the database when only the visible page (up to 100) is affected

Tests (client/src/pages/adminErrorsUtils.test.ts):

• 11 unit tests covering all branches of buildBatchDeletePayload
• Includes the specific bug scenario (selectAll + no filters)

How to test

1. Log in as a Power-tier admin
2. Navigate to Admin Error Logs (/admin/errors)
3. Ensure no level or source filter is selected (both show "All")
4. Click the "Select all" checkbox
5. Verify the label says "All N visible entries selected" (not "All matching entries selected")
6. Click "Delete selected" in the floating action bar
7. Verify entries are deleted successfully (no "Filter required" toast)
8. Also test with a filter active — should use the filter-based delete path as before

Server-side safety

No server changes. The server endpoint enforces:

• Authentication + power-tier check
• Per-entry authorization (monitor ownership or app owner)
• Zod validation with max 500 IDs
• The client query fetches at most 100 entries (limit=100)

---

https://claude.ai/code/session_012v1E6pJFJK1xhWH43SrACu

[coderabbitai]

Warning

Rate limit exceeded

@bd73-com has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 82840114-753b-4f77-a26d-b2094063a10e

📥 Commits

Reviewing files that changed from the base of the PR and between 5d22c28 and e2aa8b0.

📒 Files selected for processing (3)

• client/src/pages/AdminErrors.tsx
• client/src/pages/adminErrorsUtils.test.ts
• client/src/pages/adminErrorsUtils.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/fix-bug-v5Luw

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}