-
Notifications
You must be signed in to change notification settings - Fork 0
Fix AdminErrors camelCase mismatch (#296) #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { describe, it, expect } from "vitest"; | ||
| import type { ErrorLog } from "@shared/schema"; | ||
|
|
||
| /** | ||
| * Regression test for issue #296: the AdminErrors page used snake_case | ||
| * property names (error_type, stack_trace, etc.) but Drizzle ORM returns | ||
| * camelCase. This test ensures the schema fields that AdminErrors.tsx | ||
| * relies on exist with the expected camelCase names. | ||
| */ | ||
| describe("AdminErrors ErrorLogEntry alignment with schema", () => { | ||
| // Build a minimal ErrorLog to verify the camelCase field names exist | ||
| // at the type level. If the schema ever renames these fields, this | ||
| // test will fail at compile time (npm run check) and at runtime. | ||
| const schemaKeys: (keyof ErrorLog)[] = [ | ||
| "id", | ||
| "timestamp", | ||
| "level", | ||
| "source", | ||
| "errorType", | ||
| "message", | ||
| "stackTrace", | ||
| "context", | ||
| "resolved", | ||
| "firstOccurrence", | ||
| "occurrenceCount", | ||
| ]; | ||
|
|
||
| it("schema exports camelCase field names used by AdminErrors", () => { | ||
| // These are the fields AdminErrors.tsx references — if the schema | ||
| // renames them, this array literal will cause a TS error and the | ||
| // runtime check below will also catch it. | ||
| expect(schemaKeys).toContain("errorType"); | ||
| expect(schemaKeys).toContain("stackTrace"); | ||
| expect(schemaKeys).toContain("firstOccurrence"); | ||
| expect(schemaKeys).toContain("occurrenceCount"); | ||
| }); | ||
|
|
||
| it("schema does NOT export snake_case names", () => { | ||
| const keys = schemaKeys as string[]; | ||
| expect(keys).not.toContain("error_type"); | ||
| expect(keys).not.toContain("stack_trace"); | ||
| expect(keys).not.toContain("first_occurrence"); | ||
| expect(keys).not.toContain("occurrence_count"); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider expanding test coverage for functional edge cases.
While this schema alignment test is effective for its purpose, the
AdminErrorscomponent itself lacks test coverage for:This is outside the scope of the current fix, but worth tracking separately.
Do you want me to open an issue to track adding component-level tests for
AdminErrors.tsx?🤖 Prompt for AI Agents