Warning fixes, cleanup, and autorelease pools#10
Open
tiennou wants to merge 27 commits intobdkjones:masterfrom
Open
Warning fixes, cleanup, and autorelease pools#10tiennou wants to merge 27 commits intobdkjones:masterfrom
tiennou wants to merge 27 commits intobdkjones:masterfrom
Conversation
See quicksilver/Quicksilver#1521 (comment) for the rationale.
Conflicts: VDKQueue.m
Conflicts: VDKQueue.m
Conflicts: VDKQueue.m
Conflicts: VDKQueue.m
Conflicts: VDKQueue.m
This is *slightly* hacky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the remaining warnings I can see in VDKQueue, as well as some general cleanup.
I also had to add an autorelease pool, because now that the system frameworks are built using ARC, we're getting back autoreleased objects which will be leaked.