Easier read of log when there are multiple iframes#2
Open
danbars wants to merge 2 commits intobdo:masterfrom
Open
Easier read of log when there are multiple iframes#2danbars wants to merge 2 commits intobdo:masterfrom
danbars wants to merge 2 commits intobdo:masterfrom
Conversation
When there are multiple iframes it is sometimes hard to read the log, especially if they don't have title. Added id to each frame so you can later reference to it from the log. Use hash method so the id is consistent across refresh of the page
Owner
|
Thank @danbars !! 🎖 |
Owner
|
Looking at it a little bit more, I'm not sure it is really necessary to create a hash. Wouldn't simply displaying the |
Author
|
You could, but I think it might be a fairly long prefix for a log line. Your call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are multiple iframes it is sometimes hard to read the log, especially if they don't have title.
Added id to each frame so you can later reference to it from the log.
Use hash method so the id is consistent across refresh of the page