[FEAT/#12] teams / 팀 생성 · 조회 · 수정 · 삭제 로직 구현#21
Open
EunHaSong wants to merge 30 commits into
Open
Conversation
단, 현재 상태에서는 테스트를 진행하지 않았음.
jiwonniddaaa
requested changes
May 26, 2026
| @PatchMapping | ||
| fun updateTeamDetail( | ||
| @Parameter(hidden = true) | ||
| @RequestHeader("X-User-Public-Id") userPublicId: UUID, |
Contributor
There was a problem hiding this comment.
@AuthenticationPrincipal 어노테이션으로 JWT토큰 이용한 userId 가져오기 로직으로 해주세요!
| @RequestHeader("X-User-Public-Id") userPublicId: UUID, | ||
|
|
||
| @Parameter(hidden = true) | ||
| @RequestHeader("X-Team-Public-Id") teamPublicId: UUID, |
| } | ||
| } | ||
|
|
||
| private fun isNotChanged( |
Collaborator
There was a problem hiding this comment.
valid로 바꿔서 에러코드 반환까지 여기서 하는걸 추천합니다
youngseo22
requested changes
May 26, 2026
Contributor
youngseo22
left a comment
youngseo22
left a comment
There was a problem hiding this comment.
구웃 ~ 처음 백엔드 개발인데 너무 잘햇다 ~
Contributor
There was a problem hiding this comment.
JsonProperty로 invite_code 처럼 스네이크코드로 하면 responseBody를 스네이크코드로 받을텐데?!!
Collaborator
Author
There was a problem hiding this comment.
아하 그러면 Response와 Request 모두 수정해둘게요!!
| @PatchMapping | ||
| fun updateTeamDetail( | ||
| @Parameter(hidden = true) | ||
| @RequestHeader("X-User-Public-Id") userPublicId: UUID, |
Contributor
There was a problem hiding this comment.
@AuthenticationPrincipal 어노테이션으로 JWT토큰 이용한 userId 가져오기 로직으로 해주세요!
Comment on lines
+39
to
+40
| @Column(name = "deleted_at", nullable = true) | ||
| var deletedAt: OffsetDateTime? = null, |
Contributor
There was a problem hiding this comment.
이것도 global에 파일 하나 만들어서 사용하는 거 어떻게 생각해?
Collaborator
Author
There was a problem hiding this comment.
그러면 하나 만들어서 사용해볼까?? 나는 좋아요~
| import org.springframework.stereotype.Repository | ||
| import java.util.UUID | ||
|
|
||
| @Repository |
Contributor
There was a problem hiding this comment.
다른 레포지토리에도 이 어노테이션 붙여주쉐이 ~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업 내용
기타
> [FEAT/#9] auth / JWT로 현재 로그인 된 사용자의 userPublicId 받아오도록 #17 참고해서 다시 수정하겠음.
> 이건 나중에 테스트 후 삭제 해야 함.