builtin actor manager and scan interlock actor#877
Open
d-perl wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
624c3eb to
39a0d86
Compare
62018bb to
169d678
Compare
2f6e363 to
5fb164a
Compare
wakonig
reviewed
May 18, 2026
wakonig
reviewed
May 18, 2026
wakonig
reviewed
May 18, 2026
wakonig
reviewed
May 18, 2026
2d6f63a to
f2bb265
Compare
wakonig
reviewed
May 27, 2026
wakonig
reviewed
May 27, 2026
Member
wakonig
left a comment
There was a problem hiding this comment.
The enabling / disabling logic seems to be broken: I tried to play around with the flags in a second client but it seems not work as expected.
Scenario I: I had the interlock enabled and triggered, a scan was pending. I disabled the interlock but the scan did not continue until the returned to a valid state.
Scenario II: I started with a disabled interlock actor and enabled it mid scan. I would expect that the scan is stopped and repeated but it simply continued without respecting the beamline state.
7c29908 to
36964ab
Compare
36964ab to
2e3da91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
BuiltinActorManagerin which we can run permanently-running hardcoded actors.Adds an implementation of such, a base BeamlineStateActor and a ScanInterlockActor which locks the primary queue when specified beamline states go out of range.