Skip to content

builtin actor manager and scan interlock actor#877

Open
d-perl wants to merge 7 commits into
mainfrom
feat/scan_interlock_actor
Open

builtin actor manager and scan interlock actor#877
d-perl wants to merge 7 commits into
mainfrom
feat/scan_interlock_actor

Conversation

@d-perl
Copy link
Copy Markdown
Contributor

@d-perl d-perl commented May 8, 2026

Adds a BuiltinActorManager in which we can run permanently-running hardcoded actors.
Adds an implementation of such, a base BeamlineStateActor and a ScanInterlockActor which locks the primary queue when specified beamline states go out of range.

@d-perl d-perl changed the title wip wip scan interlock actor May 8, 2026
@d-perl d-perl changed the title wip scan interlock actor wip builtin actors and scan interlock actor May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

@d-perl d-perl force-pushed the feat/scan_interlock_actor branch 2 times, most recently from 624c3eb to 39a0d86 Compare May 8, 2026 11:23
@d-perl d-perl force-pushed the feat/beamline_actors branch 6 times, most recently from 62018bb to 169d678 Compare May 12, 2026 10:04
Base automatically changed from feat/beamline_actors to main May 12, 2026 11:28
@d-perl d-perl force-pushed the feat/scan_interlock_actor branch 6 times, most recently from 2f6e363 to 5fb164a Compare May 18, 2026 12:19
@d-perl d-perl changed the title wip builtin actors and scan interlock actor builtin actor manager and scan interlock actor May 18, 2026
@d-perl d-perl marked this pull request as ready for review May 18, 2026 12:32
@d-perl d-perl requested a review from a team May 18, 2026 12:41
Comment thread bec_ipython_client/tests/end-2-end/test_actors_e2e.py
Comment thread bec_server/bec_server/actors/scan_interlock.py Outdated
Comment thread bec_server/bec_server/actors/scan_interlock.py
Comment thread bec_lib/bec_lib/bl_state_manager.py
@d-perl d-perl force-pushed the feat/scan_interlock_actor branch 4 times, most recently from 2d6f63a to f2bb265 Compare May 20, 2026 13:13
@d-perl d-perl requested a review from wakonig May 20, 2026 13:29
@d-perl d-perl requested a review from a team May 20, 2026 13:29
Comment thread bec_server/bec_server/actors/builtin_actor_manager.py
Copy link
Copy Markdown
Member

@wakonig wakonig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enabling / disabling logic seems to be broken: I tried to play around with the flags in a second client but it seems not work as expected.

Scenario I: I had the interlock enabled and triggered, a scan was pending. I disabled the interlock but the scan did not continue until the returned to a valid state.

Scenario II: I started with a disabled interlock actor and enabled it mid scan. I would expect that the scan is stopped and repeated but it simply continued without respecting the beamline state.

@d-perl d-perl force-pushed the feat/scan_interlock_actor branch 2 times, most recently from 7c29908 to 36964ab Compare May 28, 2026 08:51
@d-perl d-perl force-pushed the feat/scan_interlock_actor branch from 36964ab to 2e3da91 Compare May 28, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants