Skip to content

fix/remove-custom-progressbar#1178

Draft
wyzula-jan wants to merge 13 commits into
mainfrom
fix/remove-custom-progressbar
Draft

fix/remove-custom-progressbar#1178
wyzula-jan wants to merge 13 commits into
mainfrom
fix/remove-custom-progressbar

Conversation

@wyzula-jan
Copy link
Copy Markdown
Contributor

@wyzula-jan wyzula-jan commented May 28, 2026

Description

Since this widget is present in MainWindow, it should be rock solid. ScanProgressbar refactored to not use its own custom paintEvent based progress bar but rather native QProgressBar.

To avoid merge conflict I would prefer to merge after #1175

@wyzula-jan wyzula-jan self-assigned this May 28, 2026
@wyzula-jan wyzula-jan force-pushed the fix/remove-custom-progressbar branch from cee4514 to dd7e029 Compare May 29, 2026 07:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 5.91908 s 5.95395 s +0.59% ok
BEC IPython client without companion app 2.21378 s 2.12282 s -4.11% ok
Import bec_widgets 0.0143291 s 0.0125641 s -12.32% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.151597 s 0.15354 s +1.28% ok

@wyzula-jan wyzula-jan force-pushed the fix/remove-custom-progressbar branch 2 times, most recently from 67b0985 to 86fa6ea Compare May 29, 2026 12:13
@wyzula-jan wyzula-jan force-pushed the fix/remove-custom-progressbar branch from 86fa6ea to 980e0dc Compare May 29, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant