fix(positioner_box): fix STOP button#1182
Merged
Merged
Conversation
wyzula-jan
force-pushed
the
fix/positioner-box-stopping-device
branch
from
e6cc003 to
0a3fa82
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the PositionerBox STOP button by routing stop requests to the dedicated immediate stop endpoint instead of queuing a device RPC.
Changes:
- Replaces emergency queue RPC stop messages with
VariableMessagesent toMessageEndpoints.stop_devices(). - Updates 2D positioner stop behavior to stop both configured axes explicitly.
- Adjusts unit tests to assert the new stop endpoint and payload.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bec_widgets/widgets/control/device_control/positioner_box/positioner_box_base.py |
Sends stop requests through the dedicated stop-devices endpoint. |
bec_widgets/widgets/control/device_control/positioner_box/positioner_box_2d/positioner_box_2d.py |
Stops both horizontal and vertical devices via the shared stop helper. |
tests/unit_tests/test_positioner_box.py |
Updates single-positioner STOP test expectations. |
tests/unit_tests/test_positioner_box_2d.py |
Adds coverage for 2D STOP behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wyzula-jan
force-pushed
the
fix/positioner-box-stopping-device
branch
from
0a3fa82 to
6f4a7f5
Compare
Contributor
Benchmark comparisonThreshold: 20% (lower is better). No benchmark regression exceeded the configured threshold. No benchmark improvement exceeded the configured threshold. All benchmark results
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed that positioner box STOP button do not stop the movement of device, this PR fix it.