feat(appservice): add app accelerator spec in resource list API#3441
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Add each bound app's accelerator spec in the compute resource list API for frontend to show more info.
Target Version for Merge
1.12.6, 1.12.7
Related Issues
none
PRs Involving Sub-Systems
none
Other information:
none
Note
Medium Risk
The listing path now depends on ApplicationManager config reads for every distinct bound app and fails the whole response on any resolution error, which can affect admin compute views when configs are missing or invalid.
Overview
The compute resources list API now returns each device binding’s currently selected resource-mode requirement (CPU/GPU/memory require & limits, multi-card / multi-node flags) inline on
Allocation.spec, so the UI can show accelerator details without extra lookups.A new read-time step
AttachBoundAppSpecsresolves that requirement once per unique(owner, appName)from the app’s ApplicationManager config and attaches it to every binding on the node tree.Specis not stored in the allocation config map. If any bound app’s config cannot be loaded or its selected mode cannot be resolved, the entire list request fails with an error.Reviewed by Cursor Bugbot for commit 6cc269e. Bugbot is set up for automated code reviews on this repo. Configure here.