Fix/resourcepack download robustness - #347
Open
wlkek wants to merge 2 commits into
Open
Conversation
When png.Decode returns an error it also returns a nil image. The surrounding code unconditionally dereferenced the nil image to compute its bounds, causing a panic in the pack-processing goroutine that aborted the entire resource pack download session - including any packs queued after the one with the broken icon. Skip the icon post-processing when decoding fails; the warning log already records the failure.
The Minecraft protocol documents ResourcePackDataInfo.UUID as a bare UUID, but some server implementations send "<uuid>_<version>" (the same string the client uses in ResourcePackClientResponse.PacksToDownload) in this field. The previous code returned a hard error for any UUID that failed to parse, which aborted the entire resource pack download session for those servers. When parsing fails, strip the suffix after the last '_' and retry. If that still does not yield a valid UUID, return the original error so the caller still sees a clear failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.