feat(doctor): verify installed plugin version truth - #35
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 068dc8aedc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| result = spawnSyncImpl("codex", ["plugin", "list", "--json"], { | ||
| encoding: "utf8", | ||
| maxBuffer: MAX_OUTPUT_BYTES, | ||
| shell: false, |
There was a problem hiding this comment.
On Windows installs where the Codex CLI is available as the usual npm-generated codex.cmd, this direct spawnSync("codex", ...) with shell: false cannot execute the shim (Node documents that .cmd files need a shell or explicit cmd.exe). The probe then returns authority_unavailable, so superloopy doctor --scope installed never gates a real stale superloopy@beefiker mismatch for those Windows users; use the same Windows shim routing pattern as the existing spawn helper for this command.
Useful? React with 👍 / 👎.
| maxBuffer: MAX_OUTPUT_BYTES, | ||
| shell: false, | ||
| stdio: ["ignore", "pipe", "pipe"], | ||
| timeout: DEFAULT_TIMEOUT_MS, |
There was a problem hiding this comment.
When the codex plugin list child wedges or traps SIGTERM, spawnSync does not actually bound this check at five seconds; it sends the timeout kill signal and then waits for the child to exit. In that scenario superloopy doctor can hang indefinitely on this informational authority probe, unlike the existing model-catalog probe that escalates to SIGKILL, so use an async child with the same terminate-and-escalate pattern instead of relying on the sync timeout alone.
Useful? React with 👍 / 👎.
| if (entry.version === executingVersion) { | ||
| return { | ||
| ok: true, | ||
| informational: true, | ||
| state: "current", |
There was a problem hiding this comment.
If Codex reports superloopy@beefiker with installed: true, enabled: false, and a matching version, this branch still returns state: "current" and installed-scope doctor exits successfully. In that disabled-plugin state Codex will not load Superloopy's hooks/skills even though the version matches, so the installed health check should report a non-current/failing state instead of telling users the Codex installation is healthy.
Useful? React with 👍 / 👎.
1 participant
Summary
codex plugin list --jsonauthority check for the exactsuperloopy@beefikerinstallation0.12.4Why
This follows merged PR #34 by closing the remaining gap between the Superloopy version executing
doctorand the version Codex reports as installed. Cache directories and wrapper siblings remain advisory only.The existing installed-scope CLI tests also assumed a healthy live Codex installation. They now assert returned doctor truth or use isolated authority fixtures, so a developer's stale local plugin cannot make the suite nondeterministic.
Validation
npm test— 678 passed, 0 failednpm pack --dry-run --json --ignore-scriptsincludessrc/installed-plugin-truth.js0.12.4git diff --check origin/main...HEAD