Remove reapply from Android Widget.__init__#3165
Merged
Merged
Conversation
Member
Author
|
With this removed, the only thing that calls |
mhsmith
approved these changes
Feb 6, 2025
Member
mhsmith
left a comment
There was a problem hiding this comment.
I'm pretty sure this is just a holdover from before #2942, when all backends had to do this.
I think you're probably right, and this PR doesn't break anything as far as I can tell. But I'll let @freakboy3742 check it before merging, because he's more familiar with the details of #2942.
freakboy3742
approved these changes
Feb 7, 2025
Member
freakboy3742
left a comment
There was a problem hiding this comment.
Agreed this should be redundant because of the changes in #2942; so it looks like it works in theory and practice! :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment about Android needing to reapply styles after a widget's constructed piqued my curiosity... Does it?
I'm pretty sure this is just a holdover from before #2942, when all backends had to do this.
PR Checklist: