Switch to Micropython-incompatible syntax#3186
Merged
freakboy3742 merged 3 commits intoFeb 12, 2025
Merged
Conversation
HalfWhitt
changed the title
Member
Author
|
(The MicroPython test is still there and failing, but #3184 will fix that.) |
freakboy3742
approved these changes
Feb 12, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Member
There was a problem hiding this comment.
I'm going to be a radical and merge this even though CI ISN'T PASSING (/me swoons)!!! 🤣
Member
Author
|
Madness! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3086 and #3151, I found once I submitted to CI that I was running up against limitations of MicroPython's syntax in
style_mixin()andBaseStyle.keys(), respectively. There's nothing wrong with what I ended up using instead... but I think my first drafts read better, and we're no longer bound by MicroPython.While I was making stylistic cleanups, I also simplified a couple of lines in
validated_property.__get__().PR Checklist: