Web migrate toga css#3891
Open
moondial-pal wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Not sure if this does the trick but did the following to validate. python -m zipfile -l dist toga_web-0.5.3.dev177+g87ddf50f1-py3-none-any.whl | grep briefcase.css~css |
freakboy3742
requested changes
Nov 16, 2025
Member
freakboy3742
left a comment
There was a problem hiding this comment.
Two comments:
- As of beeware/briefcase-web-static-template#22, the style file is named
style.css, notbriefcase.css - There's a timed element to this PR; we can't land it for at least 6 months. This is a backwards incompatible change for Briefcase, so we need to release a version of Briefcase that has the new web media handling, and then wait for that code to become widely deployed.
Contributor
Author
|
Ah, thanks for the review and the reference/link. |
Contributor
Author
|
Made the requested change to the filename. |
Member
|
Yes - I think this is all that is needed; now we wait :-) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalized migration to insert based web deployment
Removed deprecated static/toga.css file and added ...inserts/static/css/breifcase.css~css to accommodate insert based web deployment.
Fixes #3822
PR Checklist: