Fix update table in background#3903
Conversation
|
Thanks for the contribution! This doesn't seem to be working quite right. The And indeed, the toga/winforms/src/toga_winforms/widgets/detailedlist.py Lines 7 to 19 in 0d20156 I haven't gone poking at this myself, so I can't comment yet on the viability of your approach otherwise, or whether or how it fixes the issue mentioned, but it needs to at least not fail any existing tests. Speaking of testing, when we fix a bug, we need to make sure we're adding a test that confirms it's fixed. Trying it out by hand can verify it once, but it we also need to make sure it never regresses without us noticing. So for this, we'd need a test that updates the table from a background task, then verifies that the table is in fact displaying the correct thing. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Just noting here that, in order to reduce irrelevant noise, I've hidden discussion related to a confusing but entirely unrelated issue that was fixed by merging in main. |
This requests a redraw on the table when updating data from a background task.
Refs #3046
PR Checklist: