Support stand-alone Path objects in Canvas#4163
Open
corranwebster wants to merge 63 commits into
Open
Conversation
Shouldn't break anything.
19 tasks
Contributor
Author
|
Looks like a segfault on macOS Intel machines. I can replicate on an old Intel Mac on macOS Sequoia. It looks like it is an issue with |
Fix macOS x86_64 crash for Canvas Backend Path PR
Contributor
Author
|
It's been a bit of a journey, but I think this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides an implementation of Canvas paths as stand-alone objects, generally following the HTML Canvas design. In particular, this creates a top-level
Path2Dobject with path creation methods which can be used independently of any particular Canvas and re-used multiple times as needed. This has particular use when working with things like plot markers. As with the HTML canvas, paths are rendered by passing them as arguments to thefillorstrokemethods.In terms of implementation, paths wrap the backend's notion of a path as an implementation object, and the front-end "compiles" the
Path2Dto a backend path object, so drawing paths repeatedly is very efficient. The Path2D implementations are potentially reusable by third-party widgets built using the Canvas implementation (eg. plotting libraries).The PR provides a simple example as part of the canvas demo.
PR Checklist: