cocoa: submit a follow-up event after shutting down Cocoa event loop#4395
Open
rokm wants to merge 1 commit into
Open
cocoa: submit a follow-up event after shutting down Cocoa event loop#4395rokm wants to merge 1 commit into
rokm wants to merge 1 commit into
Conversation
rokm
force-pushed
the
fix-macos-app-shutdown
branch
from
48b931c to
b532ad5
Compare
Have `toga_coca.app.App.exit()` submit a follow-up event after shutting down the Cocoa event loop, to ensure that the post-stop processing occurs and that application can be closed without any user interaction. This is necessary because `rubicon-objc` 0.5.4 changed `CocoaLifecycle.stop()` to call `NSApplication.stop()` instead of `NSApplication.terminate()`, and therefore the event loop does not exit until next event is received and processed. Fixes beeware#4394.
rokm
force-pushed
the
fix-macos-app-shutdown
branch
from
b532ad5 to
66a07f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have
toga_coca.app.App.exit()submit a follow-up event after shutting down the Cocoa event loop, to ensure that the post-stop processing occurs and that application can be closed without any user interaction.This is necessary because
rubicon-objc0.5.4 changedCocoaLifecycle.stop()to callNSApplication.stop()instead ofNSApplication.terminate(), and therefore the event loop does not exit until next event is received and processed.Fixes #4394.
PR Checklist: