Skip to content

fix(canvas): Change default stroke line_width from 2.0 to 1.0#4425

Closed
jtvhd6 wants to merge 1 commit into
beeware:mainfrom
jtvhd6:fix/canvas-default-stroke-width
Closed

fix(canvas): Change default stroke line_width from 2.0 to 1.0#4425
jtvhd6 wants to merge 1 commit into
beeware:mainfrom
jtvhd6:fix/canvas-default-stroke-width

Conversation

@jtvhd6
Copy link
Copy Markdown

@jtvhd6 jtvhd6 commented May 25, 2026

Fixes #4381

The HTML5 Canvas specification defines lineWidth = 1.0 as the default.
Toga's Canvas API is intended to mirror the HTML5 Canvas API, so the
default line_width should match.

Changed the default from 2.0 to 1.0 in:

  • core/src/toga/widgets/canvas/canvas.py
  • cocoa/src/toga_cocoa/widgets/canvas.py
  • iOS/src/toga_iOS/widgets/canvas.py

@freakboy3742 freakboy3742 added the not quite right The idea or PR has been reviewed, but more work is needed. label May 25, 2026
@freakboy3742 freakboy3742 self-assigned this May 26, 2026
@freakboy3742 freakboy3742 added basic checks failing Pull request does not pass basic quality checks and removed not quite right The idea or PR has been reviewed, but more work is needed. labels May 26, 2026
@freakboy3742 freakboy3742 removed their assignment May 28, 2026
@HalfWhitt
Copy link
Copy Markdown
Member

Hi @jtvhd6, thanks for the contribution. There are some issues here. First of all, there's already a PR (#4396) in flight for this issue. There's no sense in duplicating work. Granted, that PR hasn't seen activity in a couple weeks, but it's always prudent (and polite) to drop a comment on such a PR checking in with the original author to see if they're still around and working on it, before forging ahead.

Beyond that, you can see that the towncrier check is failing; this is because this PR lacks a change note, as described in our contribution guide.

You've also deleted the checklist from the PR submission template. This has important acknowledgements we need from you:

## PR Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
- [ ] I will abide by the BeeWare Code of Conduct
- [ ] I have read and have followed the **CONTRIBUTING.md** file
- [ ] This PR was generated or assisted using an AI tool
<!-- update or delete the next line to reflect your usage -->
Assisted-by: <!--name of tool; e.g., Claude Opus 4.5-->

In particular, if this PR was written with the assistance of an AI tool — which seems likely — we need you to disclose that. Keep in mind that even if this code was generated via AI, our AI policy means you (the human user) are ultimately responsible for it, and you need to be able and available to discuss it through the review process.

@freakboy3742
Copy link
Copy Markdown
Member

Closing due to lack of response to feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

basic checks failing Pull request does not pass basic quality checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Canvas default stroke width from 2 to 1

3 participants