fix(canvas): Change default stroke line_width from 2.0 to 1.0#4425
fix(canvas): Change default stroke line_width from 2.0 to 1.0#4425jtvhd6 wants to merge 1 commit into
Conversation
|
Hi @jtvhd6, thanks for the contribution. There are some issues here. First of all, there's already a PR (#4396) in flight for this issue. There's no sense in duplicating work. Granted, that PR hasn't seen activity in a couple weeks, but it's always prudent (and polite) to drop a comment on such a PR checking in with the original author to see if they're still around and working on it, before forging ahead. Beyond that, you can see that the towncrier check is failing; this is because this PR lacks a change note, as described in our contribution guide. You've also deleted the checklist from the PR submission template. This has important acknowledgements we need from you: In particular, if this PR was written with the assistance of an AI tool — which seems likely — we need you to disclose that. Keep in mind that even if this code was generated via AI, our AI policy means you (the human user) are ultimately responsible for it, and you need to be able and available to discuss it through the review process. |
|
Closing due to lack of response to feedback. |
Fixes #4381
The HTML5 Canvas specification defines lineWidth = 1.0 as the default.
Toga's Canvas API is intended to mirror the HTML5 Canvas API, so the
default line_width should match.
Changed the default from 2.0 to 1.0 in: