Use explicit solid background color for WebView on WinForms#4434
Merged
Conversation
Fixes beeware#3264 by repainting the background that the WebView is blended behind explicitly using the WebView's APIs, rather than assuming a transparent background; although this does not uncover the root cause of beeware#3264, it is a full fix for the reported issue, as the background is always painted immediately on resizing, and thus no artifacts are ever visible.
Contributor
Author
3 tasks
phildini
reviewed
Jun 1, 2026
Member
phildini
left a comment
phildini
left a comment
There was a problem hiding this comment.
Given that this seems to conform to other places we do this, this looks fine.
Could you take a look at https://toga.beeware.org/en/stable/how-to/contribute/how/submit-pr/#pull-request-content and make sure the title of the PR conforms?
johnzhou721
changed the title
Contributor
Author
|
@phildini Done! Thanks for the guidance. |
mhsmith
approved these changes
Jun 3, 2026
Member
mhsmith
left a comment
mhsmith
left a comment
There was a problem hiding this comment.
Confirmed that this fixes the example app in the original issue.
johnzhou721
added a commit
to johnzhou721/toga
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3264 by repainting the background that the WebView is blended behind explicitly using the WebView's APIs, rather than assuming a transparent background; although this does not uncover the root cause of #3264, it is a full fix for the reported issue, as the background is always painted immediately on resizing, and thus no artifacts are ever visible.
PR Checklist:
Assisted-by: