Fix keyboard dismissal on input widgets on iOS#4452
Draft
johnzhou721 wants to merge 2 commits into
Draft
Conversation
There is already a fix for beeware#1236 in MultiLineTextInput, but the keyboard dismissal doesn't animate; fooling around with Gemini reveals that the widget must be resigned at the next event loop iteration for this to work. The why is sort of a mystery, but so is everything layout-related in iOS. After the fix, the same solution is applied to NumberInput and TextInput and manages to dismiss flawlessly on the relevant demo apps (since they can't be tested in CI). Assisted-By: Gemini
Contributor
Author
|
For core team: iOS failure seems intermittent. Can someone rerun to confirm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already a fix for #1236 in MultiLineTextInput, but the keyboard dismissal doesn't animate; fooling around with Gemini reveals that the widget must be resigned at the next event loop iteration for this to work. The why is sort of a mystery, but so is everything layout-related in iOS.
After the fix, the same solution is applied to NumberInput and TextInput and manages to dismiss flawlessly on the relevant demo apps (since they can't be tested in CI).
Refs #1236 (partial for iOS)
PR Checklist:
Assisted-by: Gemini