request-info bot works after label is added.#36
Open
knrt10 wants to merge 3 commits intobehaviorbot:masterfrom
knrt10:label
Open
request-info bot works after label is added.#36knrt10 wants to merge 3 commits intobehaviorbot:masterfrom knrt10:label
knrt10 wants to merge 3 commits intobehaviorbot:masterfrom
knrt10:label
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. |
Contributor
Author
|
@hiimbex please verify the working so that I can update some tests according to that. |
knrt10
changed the title
hiimbex
requested changes
Apr 18, 2018
Member
hiimbex
left a comment
hiimbex
left a comment
There was a problem hiding this comment.
Hi @knrt10 I'm very confused by your approach here. you're calling robot.on within a robot.on block and deleting a lot of tests that are very important. You need to look at the existing code for this bot so you don't repeat sections.
Contributor
Author
|
@hiimbex I found simpler approach let me update that. |
knrt10
changed the title
knrt10
changed the title
Contributor
Author
|
@hiimbex please review. |
mullinscjm
approved these changes
Jun 25, 2021
mullinscjm
approved these changes
Jun 25, 2021
mullinscjm
approved these changes
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #30 , now bot will work when
request-infois added as label when issue or PR is opened.