Closed
Conversation
diemtrang-bic
suggested changes
Mar 12, 2025
| public static seenStatusOfUserForNewInvitations(userId: string): string { | ||
| return [ | ||
| SharedGroupCacheKey.PREFIX, | ||
| SharedGroupCacheKey.hashTag, |
Contributor
There was a problem hiding this comment.
hashtag này để chỉ định node trong memoryDb (cái con mà lưu shared_group) do xài MemoryDb thì AWS nó bắt chạy cluster, mà mình chỉ có 1 node thôi. Còn cache xài riêng cho mỗi service thì lưu ở Elasticache, ko có cluster, nên ko cần hashtag. Dùng MemoryDb để lưu shared data xài chung cho các service do nó đảm bảo data sẽ ko mất, còn Elasticache thì mình lưu tạm bợ (có set expire).
Contributor
There was a problem hiding this comment.
cache này xài cho 1 mình service mình thôi nên ko cần lưu vô package chung nha, prefix thì mình có biến REDIS_CACHE_PREFIX rồi.
Contributor
There was a problem hiding this comment.
cc anh @quochung-bic review cái review này ổn ko nha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.