Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new activity log use case to handle delete and restore actions for groups. It adds a dedicated use-case class to record the log data and extends the existing activity log use-case enumeration.
- Added the DeleteRestoreGroupLog class to capture delete/restore group events.
- Extended the ACTIVITY_LOG_USE_CASES enum with a new DELETE_RESTORE_GROUP entry.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/activity-log/use-cases/group/delete-restore-group.use-case.ts | New class for logging delete/restore actions on groups |
| src/activity-log/enums/activity-log-use-case.enum.ts | New enum entry for the delete-restore group use case |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/activity-log/use-cases/group/delete-restore-group.use-case.ts:36
- The use-case name suggests it handles both delete and restore actions, but the eventType is set to DELETE. Consider clarifying or differentiating the event type for restoration if needed.
static readonly eventType = ACTIVITY_EVENT_TYPES.DELETE;
src/activity-log/use-cases/group/delete-restore-group.use-case.ts:67
- Consider adding unit tests for the change detection logic via GetPropsChanged to ensure both delete and restore scenarios are correctly validated.
changes: GetPropsChanged(originalState, currentState),
quochung-bic
reviewed
Apr 2, 2025
src/activity-log/use-cases/group/delete-restore-group.use-case.ts
Outdated
Show resolved
Hide resolved
quochung-bic
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.