Skip to content

Feat/bein 33405 delete group#109

Merged
quochung-bic merged 4 commits intomasterfrom
feat/BEIN-33405-delete-group
Apr 2, 2025
Merged

Feat/bein 33405 delete group#109
quochung-bic merged 4 commits intomasterfrom
feat/BEIN-33405-delete-group

Conversation

@anhtuan-bic
Copy link
Contributor

No description provided.

@anhtuan-bic anhtuan-bic requested a review from Copilot April 1, 2025 16:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new activity log use case to handle delete and restore actions for groups. It adds a dedicated use-case class to record the log data and extends the existing activity log use-case enumeration.

  • Added the DeleteRestoreGroupLog class to capture delete/restore group events.
  • Extended the ACTIVITY_LOG_USE_CASES enum with a new DELETE_RESTORE_GROUP entry.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/activity-log/use-cases/group/delete-restore-group.use-case.ts New class for logging delete/restore actions on groups
src/activity-log/enums/activity-log-use-case.enum.ts New enum entry for the delete-restore group use case
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

src/activity-log/use-cases/group/delete-restore-group.use-case.ts:36

  • The use-case name suggests it handles both delete and restore actions, but the eventType is set to DELETE. Consider clarifying or differentiating the event type for restoration if needed.
static readonly eventType = ACTIVITY_EVENT_TYPES.DELETE;

src/activity-log/use-cases/group/delete-restore-group.use-case.ts:67

  • Consider adding unit tests for the change detection logic via GetPropsChanged to ensure both delete and restore scenarios are correctly validated.
changes: GetPropsChanged(originalState, currentState),

@anhtuan-bic anhtuan-bic requested a review from quochung-bic April 2, 2025 02:00
@quochung-bic quochung-bic merged commit 0342377 into master Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants