Skip to content

🎨 Palette: Improve Navbar keyboard and screen reader accessibility#111

Open
belpythons wants to merge 1 commit into
masterfrom
palette/navbar-accessibility-2168571040023479844
Open

🎨 Palette: Improve Navbar keyboard and screen reader accessibility#111
belpythons wants to merge 1 commit into
masterfrom
palette/navbar-accessibility-2168571040023479844

Conversation

@belpythons

Copy link
Copy Markdown
Owner

What:
Added aria-expanded and aria-label attributes to the mobile menu toggle and Forum dropdown toggle in Navbar.jsx. Also added consistent focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500 classes to all interactive theme and menu toggle buttons.

Why:
The mobile menu button was an icon-only button without an aria-label, making it inaccessible to screen reader users. The interactive disclosure widgets (mobile menu and dropdowns) did not communicate their open/closed state (aria-expanded). Furthermore, interactive elements lacked explicit focus indicators, hindering keyboard navigation.

Before/After:

  • Before: Mobile menu button had no label. Theme, menu, and dropdown toggles lacked explicit focus rings. Disclosure states were not communicated.
  • After: Mobile menu button now has an aria-label. All toggles clearly display a focus ring when navigated via keyboard. Screen readers now announce whether the mobile menu or forum dropdown is expanded or collapsed.

Accessibility:

  • Resolved missing ARIA label on an icon-only button.
  • Communicated state changes using aria-expanded.
  • Enhanced keyboard navigation visibility using focus-visible ring utilities.

PR created automatically by Jules for task 2168571040023479844 started by @belpythons

Co-authored-by: belpythons <187399139+belpythons@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant