Skip to content

🎨 Palette: [UX improvement] Improve Navbar Accessibility#113

Open
belpythons wants to merge 1 commit into
masterfrom
palette/navbar-accessibility-10066964687456004852
Open

🎨 Palette: [UX improvement] Improve Navbar Accessibility#113
belpythons wants to merge 1 commit into
masterfrom
palette/navbar-accessibility-10066964687456004852

Conversation

@belpythons

Copy link
Copy Markdown
Owner

What: Added aria-expanded and aria-haspopup attributes, as well as focus-visible outline styles, to the mobile menu and dropdown toggles in the Navbar. Also fixed an unused variable linting error.

Why: To ensure that interactive disclosure widgets are fully accessible to screen reader users and can be easily navigated using a keyboard.

Before/After:

  • Before: The mobile menu toggle, dropdown button, and theme toggles lacked explicit ARIA attributes indicating their expanded state or popup availability, and lacked visible focus rings.
  • After: These elements now broadcast their states properly and show a distinct ring when focused via keyboard navigation.

Accessibility: This directly addresses WCAG standards for Name, Role, Value (4.1.2) by providing state information (aria-expanded) to assistive technologies and Focus Visible (2.4.7) by ensuring keyboard users can see which element has focus.


PR created automatically by Jules for task 10066964687456004852 started by @belpythons

…vbar widgets

Co-authored-by: belpythons <187399139+belpythons@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant