Standardize article-suite timeout fairness#23
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2189ce0095
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| terminal_error = metadata.get("terminal_error") or "" | ||
| if "PTY readline timeout" in terminal_error: |
There was a problem hiding this comment.
Check transport errors for PTY timeouts
When a selected result records the Daytona watchdog in transport_error_info (which this change now copies into metadata), this audit can still publish status: "ok" because the PTY check only searches the terminal_error string. In that scenario a cell with transport_error_info containing a PTY readline timeout would remain out of selected_timeout_influenced_cells, so the fairness audit could falsely pass; include transport_error_info/the error category in this check as well.
Useful? React with 👍 / 👎.
Summary
Audit result
Leaderboard impact
Ranking order is unchanged.
Validation
uv run python scripts/audit_article_suite_timeout_fairness.py(status: ok)uv run python scripts/validate_tasks.pyuv run bench tasks check tasks/simulation_heuristics_ant_v1 --level publication-gradeuv run python scripts/audit_simulation_heuristics_ant_v1_leaderboard.pyuv run ruff check .uv run pytest -q(108 passed, 18 skipped)uv build1/1, 100%)